Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'curator note' property to selected classes #13384

Open
cmungall opened this issue Apr 19, 2017 · 13 comments
Open

Add 'curator note' property to selected classes #13384

cmungall opened this issue Apr 19, 2017 · 13 comments
Assignees

Comments

@cmungall
Copy link
Member

On the managers call http:https://wiki.geneontology.org/index.php/Manager_Call_2017-04-19#Documentation

@pgaudet suggested improving curator documentation centered around particular terms in the ontology. I propose that we embed this directly in the ontology.

We are no longer restricted to the grab-bag 'comment' field for additional notes on a class, so I propose we create a new property or reuse something like IAO:0000232 curator note

We could add axiom annotations to each such owl annotation assertion indicating if and how this should be propagated down to descendant terms.

For some of these, it could go in the design pattern too.

By default a non-comment property will not be visible in most browsers, but these could be configured to add these.

Would this work for P2Go @tonysawfordebi?

@cmungall cmungall self-assigned this Apr 19, 2017
@ukemi
Copy link
Contributor

ukemi commented Apr 28, 2017

Discussed on the ontology editors call. We think this is a good idea. How do you find the relevant notes for child terms when the note is on a parent?
For example, don't annotate a secreted protein to Golgi.

@cmungall
Copy link
Member Author

We will have a SPARQL construct that will be run periodically to propagate these down in the editors ontology. @dougli1sqrd can implement.

@cmungall
Copy link
Member Author

cmungall commented Oct 1, 2017

@geneontology/ontology - can you provide @dougli1sqrd an example of a curator note and its associated GO ID so we can get started on this. Should we use this example: #14275 ?

@ukemi
Copy link
Contributor

ukemi commented Oct 3, 2017

[Term]
id: GO:0000084
name: mitotic S phase
namespace: biological_process
def: "The cell cycle phase, following G1, during which DNA synthesis takes place as part of a mitotic cell cycle." [GOC:mtg_cell_cycle]
comment: Note that this term should not be used for direct annotation. If you are trying to make an annotation to x phase, it is likely that the correct annotation is 'regulation of x/y phase transition' or to a process which occurs during the reported phase (i.e mitotic DNA replication for mitotic S-phase). To capture the phase when a specific location or process is observed, the phase term can be used in an annotation extension (PMID:24885854) applied to a cellular component term (with the relation exists_during) or a biological process term (with the relation happens_during).
subset: gocheck_do_not_annotate

@pgaudet
Copy link
Contributor

pgaudet commented May 31, 2018

@ukemi Should we make this 'high priority'?

@ukemi
Copy link
Contributor

ukemi commented May 31, 2018

We need examples first, don't you think?

@pgaudet
Copy link
Contributor

pgaudet commented May 31, 2018

I thought your comment above was an example.

@ukemi
Copy link
Contributor

ukemi commented May 31, 2018

OK. But I thought there was the additional step of adding a different kind of comment for obsoletions, ontology editor comments etc. We need to specify the requirements a little more.

@pgaudet
Copy link
Contributor

pgaudet commented May 31, 2018 via email

@ukemi
Copy link
Contributor

ukemi commented May 31, 2018

I didn't think so. Perhaps this is a topic for an ontology call.

@cmungall
Copy link
Member Author

cmungall commented Jun 1, 2018

@ukemi you provided mitotic S phase as an example

Did you intend to provide GO:0044848 ! biological phase as the example, with the intent that the same curator note is propagated down to all subclasses?

@ukemi
Copy link
Contributor

ukemi commented Jun 1, 2018

Yes. The point was the propagation of curator notes to children following specific properties.

@balhoff
Copy link
Member

balhoff commented Apr 24, 2020

We recently added editor note. I don't see how this differs from curator note. But we aren't doing any of this propagation. Is this still desired?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants