-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metabolism terms - add missing logical definitions #12231
Comments
Note for self - David H and Peter noted that it'd be good to do some of this similarly to glycolysis; David to add comments/examples here. Thanks @ukemi |
Note for self: this is low priority, but I'll leave it assigned to me for the time being, in case we decide I should (be the one to) address it. |
Hi @pgaudet and @cmungall |
(not yet finished) Here are terms for which I don't know how to add a logical definition
I think these are MFs and should be merged into their parent:
Does this seem OK ? lysine biosynthetic process via diaminopimelate, dehydrogenase pathway lysine biosynthetic process via diaminopimelate, diaminopimelate-aminotransferase pathway transsulfuration |
Many terms not yet done, including: 'D-alanine family amino acid catabolic process': 0 annotations 'anaerobic L-alanine catabolic process' 'anaerobic glycine catabolic process' 'lysine biosynthetic process via aminoadipic acid' ''de novo' L-methionine biosynthetic process' 'L-methionine biosynthetic process from homoserine via O-acetyl-L-homoserine and cystathionine' 'L-methionine salvage from methionine sulphoxide' 'aspartate transamidation' 'L-lysine catabolic process to glutarate, by acetylation' 'S-adenosylmethionine cycle' 'anaerobic phenylalanine oxidation' 'anaerobic glutamate catabolic process' 'histidine catabolic process to imidazol-5-yl-lactate' 'anaerobic L-alanine catabolic process' 'L-cysteine catabolic process via cystine, using cysteine transaminase' |
Can we make a push on this? Maybe I can spend an hour at the hackathon going through these? I'm very fast at adding these. D-alanine family: can we make a chebi ticket for this? I think this is a priority for the quality of the metabolic branch. Without axioms and tracing through to the actual chemical entities there are ambiguities as it's just words. With ambiguities we have lower quality, and inconsistent annotations. Also xrefs to pathway databases are suspect. With the chemical axioms in place we can automatically align to pathway databases in a robust fashion. For an example of a problem area see #17435 |
Or if you have time before. I think the new relations 'has primary input/output' should help for terms such as 'glutamate catabolic process via 2-hydroxyglutarate'. As well, a number of terms should be probably be obsoleted, such as 'anaerobic catabolism of pairs of amino acids' (this is clearly a function). Pascale |
Though logical definitions (aka ‘cross-products’) have been added broadly to the ontology, a few stray terms have escaped the effort. Making a note here as my task to look at the ‘metabolic process’ branch and add the missing defs.
(Note for self: previous work was recorded in a Jira ticket
https://www.ebi.ac.uk/panda/jira/browse/GO-110
now closed, but may wish to look into its more recent comments.)
The text was updated successfully, but these errors were encountered: