[Keyboard] Panc60 Refactor (qmk#5559)

* remove unneeded uart setting * use pragma once everywhere * remove custom matrix support * fixup readme * set bootmagic to lite * remove dependency on custom i2c code * use the right header files and function calls
foosinn · Apr 7, 2019 · 5c1ef2b · 5c1ef2b
1 parent 4109844
commit 5c1ef2b
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 296 deletions.
diff --git a/keyboards/panc60/config.h b/keyboards/panc60/config.h
@@ -39,5 +39,3 @@ along with this program. If not, see <http:https://www.gnu.org/licenses/>.
 #define NO_BACKLIGHT_CLOCK
 #define BACKLIGHT_LEVELS 1
 #define RGBLIGHT_ANIMATIONS
-
-#define NO_UART 1
diff --git a/keyboards/panc60/i2c.c b/keyboards/panc60/i2c.c
diff --git a/keyboards/panc60/i2c.h b/keyboards/panc60/i2c.h
diff --git a/keyboards/panc60/matrix.c b/keyboards/panc60/matrix.c
diff --git a/keyboards/panc60/panc60.c b/keyboards/panc60/panc60.c
@@ -24,7 +24,7 @@
 #include <avr/pgmspace.h>
 
 #include "action_layer.h"
-#include "i2c.h"
+#include "i2c_master.h"
 #include "quantum.h"
 
 __attribute__ ((weak))
@@ -44,7 +44,7 @@ void rgblight_set(void) {
  }
 
  i2c_init();
- i2c_send(0xb0, (uint8_t*)led, 3 * RGBLED_NUM);
+ i2c_transmit(0xb0, (uint8_t*)led, 3 * RGBLED_NUM, 100);
 }
 #endif
 

diff --git a/keyboards/panc60/panc60.h b/keyboards/panc60/panc60.h
@@ -13,8 +13,7 @@
  * You should have received a copy of the GNU General Public License
  * along with this program. If not, see <http:https://www.gnu.org/licenses/>.
  */
-#ifndef PANC60_H
-#define PANC60_H
+#pragma once
 
 #include "quantum.h"
 
@@ -67,5 +66,3 @@
  { K30, KC_NO, K32, K33, K34, K35, K36, K37, K38, K39, K3A, K3B, KC_NO, K3D, K3E }, \
  { KC_NO, K41, K42, KC_NO, KC_NO, KC_NO, KC_NO, K47, KC_NO, KC_NO, K4A, KC_NO, K4C, KC_NO, KC_NO } \
 }
-
-#endif
diff --git a/keyboards/panc60/readme.md b/keyboards/panc60/readme.md
@@ -14,6 +14,8 @@ Make example for this keyboard (after setting up your build environment):
 
 Flashing
 
+**Reset Key:** Hold down the key located at `K40`, commonly programmed as left control while plugging in the keyboard. You may also hold down the key located at `K00`, commonly programmed as the `Esc` key. 
+
 ps2avr(GB) boards use an atmega32a microcontroller and a different bootloader. It is not flashable using the regular QMK methods. 
 
 To put the panc60 into reset, hold left control while plugging in. 
@@ -36,9 +38,9 @@ macOS:
  ```
 3. Install the following packages:
  ```
- brew install python
- brew install pyusb
- brew install --HEAD`https://raw.githubusercontent.com/robertgzr/homebrew-tap/master/bootloadhid.rb
+ brew install python3
+ pip3 install pyusb
+ brew install --HEAD https://raw.githubusercontent.com/robertgzr/homebrew-tap/master/bootloadhid.rb
 
 4. Place your keyboard into reset. 
 5. Flash the board by typing `bootloadHID -r` followed by the path to your `.hex` file. 

diff --git a/keyboards/panc60/rules.mk b/keyboards/panc60/rules.mk
@@ -31,7 +31,7 @@ F_CPU = 12000000
 BOOTLOADER = bootloadHID
 
 # build options
-BOOTMAGIC_ENABLE = yes
+BOOTMAGIC_ENABLE = lite
 MOUSEKEY_ENABLE = yes
 EXTRAKEY_ENABLE = yes
 CONSOLE_ENABLE = yes
@@ -43,8 +43,7 @@ RGBLIGHT_CUSTOM_DRIVER = yes
 OPT_DEFS = -DDEBUG_LEVEL=0
 
 # custom matrix setup
-CUSTOM_MATRIX = yes
-SRC = matrix.c i2c.c
+SRC = i2c_master.c
 
 # programming options
 PROGRAM_CMD = ./util/atmega32a_program.py $(TARGET).hex

diff --git a/keyboards/panc60/usbconfig.h b/keyboards/panc60/usbconfig.h
@@ -8,8 +8,7 @@
  * This Revision: $Id: usbconfig-prototype.h 785 2010-05-30 17:57:07Z cs $
  */
 
-#ifndef __usbconfig_h_included__
-#define __usbconfig_h_included__
+#pragma once
 
 #include "config.h"
 
@@ -392,5 +391,3 @@ section at the end of this file).
 /* #define USB_INTR_PENDING EIFR */
 #define USB_INTR_PENDING_BIT INTF1
 #define USB_INTR_VECTOR INT1_vect
-
-#endif /* __usbconfig_h_included__ */