[Impeller] Process ImpellerC include paths the same way as output paths #37335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
Nov 4, 2022
zanderso
reviewed
Nov 4, 2022
impeller/compiler/utilities.cc
Outdated
| @@ -11,9 +11,13 @@ | |||
| namespace impeller { | |||
| namespace compiler { | |||
|
|
|||
| std::string Utf8FromPath(const std::filesystem::path& path) { | |||
| return reinterpret_cast<const char*>(path.stem().u8string().c_str()); | |||
There was a problem hiding this comment.
Is the stem() part right everywhere?
bdero
force-pushed
the
bdero/impellerc-utf8-util
branch
from
5b593ca
to
1c234bd
Compare
zanderso
approved these changes
Nov 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 5, 2022
…114732) * aeae6afb7 Roll Dart SDK from b2aad7caafc9 to d97d5ad98893 (1 revision) (flutter/engine#37333) * 396be860f [Impeller] Remove cached pipelines when RuntimeStage is hot reloaded (flutter/engine#37307) * 223a485ce Handle include paths the same way as output paths (flutter/engine#37335)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#114732) * aeae6afb7 Roll Dart SDK from b2aad7caafc9 to d97d5ad98893 (1 revision) (flutter/engine#37333) * 396be860f [Impeller] Remove cached pipelines when RuntimeStage is hot reloaded (flutter/engine#37307) * 223a485ce Handle include paths the same way as output paths (flutter/engine#37335)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#114732) * aeae6afb7 Roll Dart SDK from b2aad7caafc9 to d97d5ad98893 (1 revision) (flutter/engine#37333) * 396be860f [Impeller] Remove cached pipelines when RuntimeStage is hot reloaded (flutter/engine#37307) * 223a485ce Handle include paths the same way as output paths (flutter/engine#37335)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without having reproduced the problem yet, I'm hoping this will fix the Windows test failure in flutter/flutter#114214. Either way, this refactor simplifies an ugly aspect of the code.
This moves our "works everywhere" solution for utf8-respecting paths to a utility method, and passes include input paths through it.
History of how we got here:
#36158
#36223