[Impeller] Cast chat8_t* to char* for MSSTL compat #36223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed when syncing impeller-cmake.
In MSSTL,
Path::u8string
returns anstd::u8string
, which is spec abiding. However, libcxx returns anstd::string
. Our interfaces useconst char*
andstd::string
for paths, but Clang doesn't do implicit conversions forchar8_t
->char
. This is a safe cast because the underlying type ofchar8_t
is defined by the spec to beunsigned char
.