Skip to content

Commit

Permalink
Meta: Don't run qemu as root
Browse files Browse the repository at this point in the history
This currently only supports Linux but I don't think anyone else
ran this yet because they'd have run into the E1000 bug I fixed
in SerenityOS#6669
  • Loading branch information
gunnarbeutner authored and awesomekling committed Apr 27, 2021
1 parent bf703ee commit 6652ce1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion Meta/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,16 @@ elif [ "$SERENITY_RUN" = "qn" ]; then
-append "${SERENITY_KERNEL_CMDLINE}"
elif [ "$SERENITY_RUN" = "qtap" ]; then
# Meta/run.sh qtap: qemu with tap
sudo "$SERENITY_QEMU_BIN" \
sudo ip tuntap add dev tap0 mode tap user "$(id -u)"
"$SERENITY_QEMU_BIN" \
$SERENITY_COMMON_QEMU_ARGS \
$SERENITY_VIRT_TECH_ARG \
$SERENITY_PACKET_LOGGING_ARG \
-netdev tap,ifname=tap0,id=br0 \
-device e1000,netdev=br0 \
-kernel Kernel/Kernel \
-append "${SERENITY_KERNEL_CMDLINE}"
sudo ip tuntap del dev tap0 mode tap
elif [ "$SERENITY_RUN" = "qgrub" ]; then
# Meta/run.sh qgrub: qemu with grub
"$SERENITY_QEMU_BIN" \
Expand Down

0 comments on commit 6652ce1

Please sign in to comment.