Kernel: Make sure the E1000 network adapter keeps receiving packets #6669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarbeutner
force-pushed
the
e1000-fixes
branch
from
084432a
to
43963fa
Compare
|
@supercomputer7 I was told you might be able to test this if you have some spare time. While this works just fine I wonder if it also works with real hardware. |
Me? Well, getting an Intel Ethernet card is still a goal I ought to achieve, so the answer unfortunately is that I can't test it right now. Nevertheless, the patch looks good. I might have a few points to indicate to fix, so everything will be marvelous :) |
gunnarbeutner
added a commit
to gunnarbeutner/serenity
that referenced
this pull request
Apr 26, 2021
This currently only supports Linux but I don't think anyone else ran this yet because they'd have run into the E1000 bug I fixed in SerenityOS#6669
gunnarbeutner
added a commit
to gunnarbeutner/serenity
that referenced
this pull request
Apr 27, 2021
This currently only supports Linux but I don't think anyone else ran this yet because they'd have run into the E1000 bug I fixed in SerenityOS#6669
Previously the E1000 network adapter would stop receiving further packets when an RX buffer overrun occurred. This was the case when connecting the adapter to a real network where enough broadcast traffic caused the buffer to be full before the kernel had a chance to clear the RX buffer.
gunnarbeutner
force-pushed
the
e1000-fixes
branch
from
43963fa
to
c1e45ca
Compare
awesomekling
pushed a commit
that referenced
this pull request
Apr 27, 2021
This currently only supports Linux but I don't think anyone else ran this yet because they'd have run into the E1000 bug I fixed in #6669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the E1000 network adapter would stop receiving further packets when an RX buffer overrun occurred. This was the case when connecting the adapter to a real network where enough broadcast traffic caused the buffer to be full before the kernel had a chance to clear the RX buffer.
This also updates the E1000 module to use macros instead of hard-coded magic values.
Further it adds logging for E1000 RX buffer overruns and avoids resetting the IRQ mask on each interrupt.