-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not hard-code fusermount, add option or auto-detect instead #5695
Conversation
This all looks good for meson but flatpak still supports autotools also. |
Honestly, I'm tempted to resolve that by removing Autotools from the main branch... For 1.14.x (or Autotools in 1.15.x if we're keeping it), an
|
👍 🎆 🥳 🎉 |
2d80e04
to
f89cbb3
Compare
I have to admit, I'd rather wait some months (while continue carrying a downstream patch) than even try fix autotools (more if it's on its way out). I certainly have the patience for that :) |
As discussed in flatpak#5695, I think we're reaching a point where removing Autotools is preferable to fixing it. 1.14.x continues to use Autotools, so platforms whose Meson version is too old can stay on that branch until it becomes unsupported. We have a very conservative Meson dependency (Ubuntu 20.04). Signed-off-by: Simon McVittie <[email protected]>
As discussed in flatpak#5695, I think we're reaching a point where removing Autotools is preferable to fixing it. 1.14.x continues to use Autotools, so platforms whose Meson version is too old can stay on that branch until it becomes unsupported. We have a very conservative Meson dependency (Ubuntu 20.04). Signed-off-by: Simon McVittie <[email protected]>
As discussed in flatpak#5695, I think we're reaching a point where removing Autotools is preferable to fixing it. 1.14.x continues to use Autotools, so platforms whose Meson version is too old can stay on that branch until it becomes unsupported. We have a very conservative Meson dependency (Ubuntu 20.04). Signed-off-by: Simon McVittie <[email protected]>
As discussed in flatpak#5695, I think we're reaching a point where removing Autotools is preferable to fixing it. 1.14.x continues to use Autotools, so platforms whose Meson version is too old can stay on that branch until it becomes unsupported. We have a very conservative Meson dependency (Ubuntu 20.04). Signed-off-by: Simon McVittie <[email protected]>
As discussed in flatpak#5695, I think we're reaching a point where removing Autotools is preferable to fixing it. 1.14.x continues to use Autotools, so platforms whose Meson version is too old can stay on that branch until it becomes unsupported. We have a very conservative Meson dependency (Ubuntu 20.04). Signed-off-by: Simon McVittie <[email protected]>
As discussed in flatpak#5695, I think we're reaching a point where removing Autotools is preferable to fixing it. 1.14.x continues to use Autotools, so platforms whose Meson version is too old can stay on that branch until it becomes unsupported. We have a very conservative Meson dependency (Ubuntu 20.04). Signed-off-by: Simon McVittie <[email protected]>
As discussed in #5695, I think we're reaching a point where removing Autotools is preferable to fixing it. 1.14.x continues to use Autotools, so platforms whose Meson version is too old can stay on that branch until it becomes unsupported. We have a very conservative Meson dependency (Ubuntu 20.04). Signed-off-by: Simon McVittie <[email protected]>
@pabloyoyoista: Please rebase on git main when convenient, now that it's Meson-only. The Meson build will now be tested on Ubuntu 20.04, which might reveal some lurking backwards-compatibility issues if we didn't spot them during review. |
The hard-coding is not appropriate. According to libfuse 3.0.0 release notes: "The fusermount and mount.fuse binaries have been renamed to fusermount3 and mount.fuse3 to allow co-installation of libfuse 2.x and 3.x". Some distributions seem to install a symlink, but this is not upstream's default behavior. In addition, fusermount might be provided from non-distro sources. So a build-time option takes precedence over auto-detection logic. Fixes flatpak#5104 Fixes flatpak#5694
f89cbb3
to
47fe002
Compare
Rebased, seems like tests are running, so hopefully the meson part worked out as expected 🎉 Thanks a lot for doing this!! |
As discussed in flatpak#5695, I think we're reaching a point where removing Autotools is preferable to fixing it. 1.14.x continues to use Autotools, so platforms whose Meson version is too old can stay on that branch until it becomes unsupported. We have a very conservative Meson dependency (Ubuntu 20.04). Signed-off-by: Simon McVittie <[email protected]>
The hard-coding is not appropriate. According to libfuse 3.0.0 release notes: "The fusermount and mount.fuse binaries have been renamed to fusermount3 and mount.fuse3 to allow co-installation of libfuse 2.x and 3.x". Some distributions seem to install a symlink, but this is not upstream's default behavior.
In addition, fusermount might be provided from non-distro sources. So a build-time option takes precedence over auto-detection logic.
Fixes #5104
Fixes #5694
executable.path()
is deprecated in meson, butfull_path
was only available in 0.55, and the minimum version is 0.53. So I guess this introduces a bit of technical debt...@smcv as promised