populate_commit_data_cache: Don't leak a floating GVariant

var_variant_dup_to_gvariant() returns a floating GVariant, and g_variant_get_child_value() won't sink it, so we need to free it. Signed-off-by: Simon McVittie <[email protected]>
flatpak · Feb 15, 2024 · a96834b · a96834b
1 parent fd56fb8
commit a96834b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/common/flatpak-utils.c b/common/flatpak-utils.c
@@ -3300,7 +3300,7 @@ populate_commit_data_cache (OstreeRepo *repo,
  strcmp (m_key, "xa.data") != 0)
  {
  VarVariantRef v = var_metadata_entry_get_value (m);
- GVariant *vv = var_variant_dup_to_gvariant (v);
+ g_autoptr(GVariant) vv = g_variant_ref_sink (var_variant_dup_to_gvariant (v));
  g_autoptr(GVariant) child = g_variant_get_child_value (vv, 0);
  g_variant_builder_add (&sparse_builder, "{sv}", m_key, child);
  has_sparse = TRUE;