populate_commit_data_cache: Don't leak child value

g_variant_get_child_value() returns a non-floating reference, so g_variant_builder_add() will not sink it. Signed-off-by: Simon McVittie <[email protected]>
flatpak · Feb 15, 2024 · fd56fb8 · fd56fb8
1 parent b97704d
commit fd56fb8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/common/flatpak-utils.c b/common/flatpak-utils.c
@@ -3301,7 +3301,8 @@ populate_commit_data_cache (OstreeRepo *repo,
  {
  VarVariantRef v = var_metadata_entry_get_value (m);
  GVariant *vv = var_variant_dup_to_gvariant (v);
- g_variant_builder_add (&sparse_builder, "{sv}", m_key, g_variant_get_child_value (vv, 0));
+ g_autoptr(GVariant) child = g_variant_get_child_value (vv, 0);
+ g_variant_builder_add (&sparse_builder, "{sv}", m_key, child);
  has_sparse = TRUE;
  }
  }