Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of setJointAnglesSequenceFull function in SequencePlayer (updated by snozawa) #908

Merged
merged 7 commits into from
Dec 15, 2015

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Dec 14, 2015

#883
にさらに修正を加えたPRになります。
PRされてるbranchにPRする方法をど忘れしたので、
https://github.com/fkanehiro/hrpsys-base/pull/883をふくんでこちらになります。

@mmurooka さん
python関数のclearのcheckが現状通らないであってますか?

@k-okada
Copy link
Contributor

k-okada commented Dec 14, 2015

Refer to this link for build results (access rights to CI server needed):
http:https://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/hrpsys-qnx/2461/

Build Log
last 10 lines

[...truncated 3694 lines...]
    at org.jenkinsci.plugins.ghprb.GhprbRepository.createCommitStatus(GhprbRepository.java:122)
    at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:118)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:27)
    at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:12)
    at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:201)
    at hudson.model.Run.execute(Run.java:1783)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:410)

Test FAILed.

@snozawa
Copy link
Contributor Author

snozawa commented Dec 15, 2015

こちらtravis通りましたので、ご確認いただけますと助かります

fkanehiro added a commit that referenced this pull request Dec 15, 2015
fix bug of setJointAnglesSequenceFull function in SequencePlayer (updated by snozawa)
@fkanehiro fkanehiro merged commit 740d8ba into fkanehiro:master Dec 15, 2015
@mmurooka
Copy link
Contributor

python関数のclearのcheckが現状通らないであってますか?

お返事遅くなりました.
現状は通っていなかったです.

@snozawa
Copy link
Contributor Author

snozawa commented Dec 17, 2015

Issueにしておいてもらえると助かります。
test codeはコメントアウトした部分で良いと思うので。

@mmurooka
Copy link
Contributor

私の手元のPCだと何回かやって通りました.
travisでは再現性をもって失敗していたので,travisのテスト時特有の問題のようです.

@k-okada
Copy link
Contributor

k-okada commented Dec 17, 2015

何回かやって通りました、は
何回かやって全部通りました

何回かやって一回通りました
のどちらだろう

@mmurooka
Copy link
Contributor

何回かやって全部通りました

です.

@k-okada
Copy link
Contributor

k-okada commented Dec 18, 2015

travisが正として,通ること自体がmurook環境特有の問題,という風に解釈するのがいいでしょう.

◉ Kei Okada

On Thu, Dec 17, 2015 at 10:51 PM, Masaki Murooka [email protected]
wrote:

何回かやって全部通りました
です.


Reply to this email directly or view it on GitHub
#908 (comment)
.

@mmurooka
Copy link
Contributor

はい,ご指摘の通りに思いまして,
自分のbranchでもtravisを有効にして確認するようにしました.
#913 (comment)

@snozawa snozawa deleted the fix-seq-bug-20151121-mmurooka branch December 18, 2015 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants