Fix issue with Python Functions when path has spaces #5858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
approved these changes
May 17, 2023
Co-authored-by: Daniel Lee <[email protected]>
tonyjhuang
pushed a commit
that referenced
this pull request
May 22, 2023
<!-- Thank you for contributing to the Firebase community! Please fill out the form below. Run the linter and test suite ============================== Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine. We've hooked up this repo with continuous integration to double check those things for you. --> ### Description <!-- Are you fixing a bug? Implementing a new feature? Make sure we have the context around your change. Link to other relevant issues or pull requests. --> Proposed fix for #5854. Related to #5830. Issue seems to be similar as the error message shows the incomplete path when path has spaces. e.g. if path is `/Users/<user>/Desktop/project directory/function`, error message will shows path `/Users/<user>/Desktop/project`. ### Scenarios Tested <!-- Write a list of all the user journeys and edge cases you've tested. Instructions for manual testing can be found at https://github.com/firebase/firebase-tools/blob/master/.github/CONTRIBUTING.md#development-setup --> 1. Create a directory with a space 2. Run `firebase init functions` and run through the setup for Python functions. 3. Run `firebase init emulators` and setup the functions emulator 4. Run `firebase emulators:start` ### Sample Commands <!-- Proposing a change to commands or flags? Provide examples of how they will be used. --> `firebase emulators:start`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposed fix for #5854.
Related to #5830. Issue seems to be similar as the error message shows the incomplete path when path has spaces. e.g. if path is
/Users/<user>/Desktop/project directory/function, error message will shows path/Users/<user>/Desktop/project.Scenarios Tested
firebase init functionsand run through the setup for Python functions.firebase init emulatorsand setup the functions emulatorfirebase emulators:startSample Commands
firebase emulators:start