-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Functions emulator fails with space in project directory path #5854
Comments
This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information. |
Hi @benbrunyee, thanks for reporting this issue. I was able to replicate the behavior you mentioned using firebase-tools v12.0.1 on a macOS machine by following steps similar to the one provided in your test case:
That said, I’ll notify our team about this so that we can investigate this issue. I'll also be marking this issue as reproducible. |
<!-- Thank you for contributing to the Firebase community! Please fill out the form below. Run the linter and test suite ============================== Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine. We've hooked up this repo with continuous integration to double check those things for you. --> ### Description <!-- Are you fixing a bug? Implementing a new feature? Make sure we have the context around your change. Link to other relevant issues or pull requests. --> Proposed fix for #5854. Related to #5830. Issue seems to be similar as the error message shows the incomplete path when path has spaces. e.g. if path is `/Users/<user>/Desktop/project directory/function`, error message will shows path `/Users/<user>/Desktop/project`. ### Scenarios Tested <!-- Write a list of all the user journeys and edge cases you've tested. Instructions for manual testing can be found at https://github.com/firebase/firebase-tools/blob/master/.github/CONTRIBUTING.md#development-setup --> 1. Create a directory with a space 2. Run `firebase init functions` and run through the setup for Python functions. 3. Run `firebase init emulators` and setup the functions emulator 4. Run `firebase emulators:start` ### Sample Commands <!-- Proposing a change to commands or flags? Provide examples of how they will be used. --> `firebase emulators:start`
The issue should be resolved in the next release. Thank you for reporting the issue! |
<!-- Thank you for contributing to the Firebase community! Please fill out the form below. Run the linter and test suite ============================== Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine. We've hooked up this repo with continuous integration to double check those things for you. --> ### Description <!-- Are you fixing a bug? Implementing a new feature? Make sure we have the context around your change. Link to other relevant issues or pull requests. --> Proposed fix for #5854. Related to #5830. Issue seems to be similar as the error message shows the incomplete path when path has spaces. e.g. if path is `/Users/<user>/Desktop/project directory/function`, error message will shows path `/Users/<user>/Desktop/project`. ### Scenarios Tested <!-- Write a list of all the user journeys and edge cases you've tested. Instructions for manual testing can be found at https://github.com/firebase/firebase-tools/blob/master/.github/CONTRIBUTING.md#development-setup --> 1. Create a directory with a space 2. Run `firebase init functions` and run through the setup for Python functions. 3. Run `firebase init emulators` and setup the functions emulator 4. Run `firebase emulators:start` ### Sample Commands <!-- Proposing a change to commands or flags? Provide examples of how they will be used. --> `firebase emulators:start`
[REQUIRED] Environment info
firebase-tools: 12.0.1
Platform: Windows
[REQUIRED] Test case
firebase init functions
and run through the setup forPython
functions.firebase init functions
to get dependencies installedfirebase init emulators
and setup thefunctions
emulatorfirebase emulators:start
and see error below:[REQUIRED] Steps to reproduce
(More environment info)
yarn --version
=1.22.19
vite --version
=vite/4.3.3 win32-x64 node-v16.13.2
yarn create vite
. SelectSvelteKit
andTypeScript
as the options. The project name here does not matterfirebase init functions
and run through the setup forPython
functions.firebase init functions
to get dependencies installedfirebase init emulators
and setup thefunctions
emulatorfirebase emulators:start
and see error below:[REQUIRED] Expected behavior
The functions emulator should be able to handle spaces in directory paths.
This should work in Git Bash, CMD, PowerShell
[REQUIRED] Actual behavior
The emulator fails to run unless I modify the path to remove the space.
This is the case when running using Git Bash, CMD and PowerShell
The text was updated successfully, but these errors were encountered: