Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for discovering functions from a project repository. #5214

Merged
merged 10 commits into from
Dec 13, 2022

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Nov 4, 2022

Add new integration test for discovering function triggers in a project.

Here, we test couple of simple project setups:

  1. simple: Plain ol' project with funcntions directory
  2. esm: Like simple but functions are packages as an es module.
  3. codebases: Multiple functions spread across codebases

The test can be run locally with npm run test:functions-discover.

@taeold
Copy link
Contributor Author

taeold commented Nov 4, 2022

@taeold
Copy link
Contributor Author

taeold commented Nov 4, 2022

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Base: 56.27% // Head: 56.27% // No change to project coverage 👍

Coverage data is based on head (95a4810) compared to base (420c253).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           dl-fn-discovery-cmd    #5214   +/-   ##
====================================================
  Coverage                56.27%   56.27%           
====================================================
  Files                      309      309           
  Lines                    20838    20838           
  Branches                  4227     4227           
====================================================
  Hits                     11726    11726           
  Misses                    8100     8100           
  Partials                  1012     1012           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taeold taeold force-pushed the dl-cf3-discover-test branch 2 times, most recently from 960f1b4 to 1d21dee Compare November 4, 2022 23:05
@taeold taeold marked this pull request as ready for review November 7, 2022 14:16
@taeold
Copy link
Contributor Author

taeold commented Dec 13, 2022

Graphite Merge Job

Current status: ✅ Merged

This pull request was successfully merged as part of a stack.

This comment was auto-generated by Graphite.

Job Reference: Uhty8UE38l3MKEIRA9gp

@taeold taeold changed the base branch from dl-fn-discovery-cmd to master December 13, 2022 18:52
@taeold taeold merged commit 7bcbf8e into master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants