Add new command for discoverying function triggers.

[taeold]

Adds an internal CLI command for discovering function triggers in a given project directory:

$ cd my-project
$ ls
firebase.json
functions/
$ firebase internaltesting:functions:discover
{
  "default": {
    "requiredAPIs": [],
    "endpoints": [
      {
        id: "helloWorld",
        platform: "gcfv2",
        ...
      },
      ...
    ]
  }
}

I intend to use the command to wire up integration test for discovery portion of a function deployment in the follow up PR.

This PR makes a small refactoring of the function deployment code to extract out the pieces for discovering functions. I verified that the function deploy integration test still passes after this refactor (Test Run).

DO NOT MERGE: New command requires an internal API proposal approval.

[taeold]

Current dependencies on/for this PR:

• master
  • PR Add support for internal testing-only commands. #5289
    • PR Add new command for discoverying function triggers. #5213 👈
      • PR Add integration test for discovering functions from a project repository. #5214
        • PR Fix bug where function discovery failed on projects using yarn workspaces. #5215

This comment was auto-generated by Graphite.

[codecov-commenter]

Codecov Report

Base: 56.36% // Head: 56.33% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (cfdb639) compared to base (2e88691).
Patch coverage: 14.28% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5213      +/-   ##
==========================================
- Coverage   56.36%   56.33%   -0.04%     
==========================================
  Files         313      313              
  Lines       21056    21066      +10     
  Branches     4278     4278              
==========================================
- Hits        11869    11868       -1     
- Misses       8161     8172      +11     
  Partials     1026     1026              

Impacted Files	Coverage Δ
src/deploy/functions/prepare.ts	31.57% <7.69%> (-1.09%)	⬇️
src/deploy/functions/params.ts	37.50% <100.00%> (ø)
src/emulator/auth/state.ts	84.87% <0.00%> (-0.57%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[colerogers]

I would take the side of running this through API council since it has to be public facing and they might have naming suggestions for internal only commands.

Alternatively, I think we should at least get @bkendall's sign-off as the CLI TL before merging this

[taeold]

@colerogers Since @bkendall won't be back for some time, I'll go ahead and draft an API proposal.

[TheIronDev]

Should this JSON.stringify be try/catch'd ?

[taeold]

I feel like that edge case is rare enough, and we can rely on the CLI's global try-catch mechanism. We are going to rethrow the error anyway right?

WDYT?

[colerogers]

🔥

[taeold]

Graphite Merge Job

Current status: ✅ Merged

This pull request was successfully merged as part of a stack.

This comment was auto-generated by Graphite.

Job Reference: Uhty8UE38l3MKEIRA9gp