Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to customize the exit code send in cli context #689

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Allow to customize the exit code send in cli context #689

merged 1 commit into from
Mar 19, 2021

Conversation

lode
Copy link
Contributor

@lode lode commented Mar 19, 2021 •
edited
Loading

Fixes #688

denis-sokolov
denis-sokolov requested changes Mar 19, 2021
View reviewed changes
Copy link
Collaborator

@denis-sokolov denis-sokolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superbly clean, thank you!

Some clarification with the allowed range is needed, could you take a look and clarify what you meant? Thanks.

src/Whoops/Run.php Show resolved Hide resolved
tests/Whoops/RunTest.php Show resolved Hide resolved
@denis-sokolov denis-sokolov merged commit 2d0f391 into filp:master Mar 19, 2021
@lode
Copy link
Contributor Author

lode commented Mar 19, 2021

Thanks a lot for the quick working along!

@lode lode deleted the customize-exit-code branch March 19, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-sokolov denis-sokolov denis-sokolov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decide which exit code to send
2 participants
@lode @denis-sokolov