Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide which exit code to send #688

Closed
lode opened this issue Mar 18, 2021 · 1 comment · Fixed by #689
Closed

Decide which exit code to send #688

lode opened this issue Mar 18, 2021 · 1 comment · Fixed by #689

Comments

@lode
Copy link
Contributor

lode commented Mar 18, 2021

It would be nice if we could decide which exit code gets send to CLI, in the same way we can do that with HTTP response codes. Right now $this->system->stopExecution(1); is being called which hard codes this.

I'm willing to setup a PR for this if this is a desired direction.
@denis-sokolov
Copy link
Collaborator

Sounds like a perfectly valid option to add! I think it would be close to allowQuit option we have on Run.

@lode lode mentioned this issue Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to customize the exit code send in cli context
2 participants
@denis-sokolov @lode