Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Wrap file names in the grid layout #10541

Conversation

GabrieleMessina
Copy link

Resolved / Related Issues

Changes

  • Add Selected property to ListedItem class;
  • Increased file name TextBlock's height for showing 3 lines when on 100% system text scale;
  • Add ScrollViewer to selected ListedItem to be able to read the entire name if it's long;

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots
image
image
image

Add Selected property to ListedItem class,
Incresed file name TextBlock's height for showing 3 lines when on 100% system text scale,
Add ScrollViewer to selected ListedItem to be able to read the entire name if it's long
@yaira2
Copy link
Member

yaira2 commented Nov 23, 2022

What happens if you have multiple rows? Does the item height increase for all the rows even if there aren't multiple lines of text?

@GabrieleMessina
Copy link
Author

@yaira2

What happens if you have multiple rows? Does the item height increase for all the rows even if there aren't multiple lines of text?

Yes, because i believe the row height is given by the first element, not by the highest. So i've set the height of the TextBlock to 60.

image

@yaira2
Copy link
Member

yaira2 commented Nov 23, 2022

This is going to be an issue because the first row is taller than it needs to be...

@GabrieleMessina
Copy link
Author

I understand, but i don't know how to fix this. Do you have any suggestions?

I've checked, and the AdaptiveGridView doesn't give us any control over row height and i can't access or find the first element for each row because I don't know how many items there are in each one.

@yaira2
Copy link
Member

yaira2 commented Nov 24, 2022

I'm not really sure, I tried different solutions in the past but none of them works as expected.

@yaira2 yaira2 closed this Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Wrap file names in the grid layout
2 participants