Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Wrap file names in the grid layout #1033

Open
chuchanpr opened this issue Jun 12, 2020 · 7 comments · Fixed by #10972 or #13852
Open

Feature: Wrap file names in the grid layout #1033

chuchanpr opened this issue Jun 12, 2020 · 7 comments · Fixed by #10972 or #13852
Labels
feature request help wanted Extra attention is needed

Comments

@chuchanpr
Copy link

chuchanpr commented Jun 12, 2020 •
edited by yaira2
Loading

Requirements

  • File names should wrap up to three lines in the grid view layouts.
  • Selected items names should wrap as many lines as necessary to show the complete name
@chuchanpr chuchanpr added the bug Something isn't working 👀 label Jun 12, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.67. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@ghost ghost added the needs-triage label Jun 12, 2020
@lukeblevins
Copy link
Contributor

We'll need to handle Item Selection when using the new ItemsRepeater

@yaira2 yaira2 added enhancement and removed bug Something isn't working 👀 labels Nov 27, 2020
@gave92 gave92 mentioned this issue Feb 19, 2021
Closed
@winston-de winston-de mentioned this issue May 23, 2021
Closed
This was referenced Nov 14, 2021
Closed
Closed
@yaira2 yaira2 mentioned this issue Nov 24, 2021
Closed
This was referenced Dec 6, 2021
Closed
Closed
@yaira2 yaira2 mentioned this issue Jan 4, 2022
Closed
@yaira2 yaira2 added the good first issue Good issue for new contributors to get started with label Jan 17, 2022
@yaira2 yaira2 mentioned this issue Mar 1, 2022
Closed
@Josh65-2201 Josh65-2201 mentioned this issue Jul 30, 2022
Closed
@yaira2 yaira2 changed the title Allow wrapping of files names and show full file names in Grid view Feature: Wrap file names in the grid layout Sep 8, 2022
@yaira2 yaira2 mentioned this issue Sep 8, 2022
Closed
@yaira2 yaira2 mentioned this issue Nov 15, 2022
Closed
GabrieleMessina added a commit to GabrieleMessina/Files that referenced this issue Nov 22, 2022
@GabrieleMessina
Grid layout UI tweaks. Fix files-community#1033
13fc0e3 
Add Selected property to ListedItem class,
Incresed file name TextBlock's height for showing 3 lines when on 100% system text scale,
Add ScrollViewer to selected ListedItem to be able to read the entire name if it's long
@GabrieleMessina GabrieleMessina mentioned this issue Nov 23, 2022
Closed
2 tasks
@Josh65-2201 Josh65-2201 mentioned this issue Nov 24, 2022
Closed
This was referenced Dec 15, 2022
Closed
Closed
@yaira2 yaira2 mentioned this issue Jan 1, 2023
Closed
@yaira2 yaira2 mentioned this issue Jan 10, 2023
Merged
2 tasks
@yaira2 yaira2 reopened this Jan 11, 2023
@yaira2
Copy link
Member

yaira2 commented Jan 11, 2023

We had to revert this feature because the implementation was causing this issue #10983

@yaira2 yaira2 mentioned this issue Jan 25, 2023
Closed
@yaira2 yaira2 added the help wanted Extra attention is needed label Apr 3, 2023
@yaira2 yaira2 mentioned this issue May 30, 2023
Closed
This was referenced Aug 9, 2023
Closed
Closed
@yaira2 yaira2 mentioned this issue Nov 13, 2023
Merged
1 task
@yaira2 yaira2 reopened this Mar 10, 2024
@yaira2 yaira2 removed the good first issue Good issue for new contributors to get started with label Mar 10, 2024
@yaira2
Copy link
Member

yaira2 commented Mar 10, 2024

Reopening this issue as it's not yet fully resolved.

@yaira2 yaira2 mentioned this issue Mar 10, 2024
Closed
@0x5bfa
Copy link
Member

0x5bfa commented Apr 28, 2024

https://github.com/sbaeumlisberger/VirtualizingWrapPanel/tree/master/src

Do you guys think this might be helpful?

@yaira2
Copy link
Member

yaira2 commented May 1, 2024

It's for WPF but it would be interesting to see if it could be ported. Fyi @marcelwgn

@marcelwgn
Copy link
Contributor

We could have the textblocks wrap on their own, however I don't think GridView would be able to deal with one textblock being larger than others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request help wanted Extra attention is needed
Projects
Files task board
Status: 🔖 Ready to build
Milestone
No milestone
5 participants
@chuchanpr @marcelwgn @lukeblevins @yaira2 @0x5bfa