Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace also div tags not only code tags #22

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

ChrisOboe
Copy link
Contributor

fixes #21

i'm not a ruby dev so i don't know if this is a proper solution or a ugly hack.
at least it works.

@felixvanoost felixvanoost self-assigned this Feb 27, 2024
@felixvanoost
Copy link
Owner

Hey @ChrisOboe, thanks for finding this bug and taking the time to resolve it! I just condensed your additional loop into the original one by iterating through the two HTML tags we care about (code and div). I'm also not a Ruby developer so there's probably a more elegant way than both of ours. 😂

@felixvanoost felixvanoost merged commit ad0cd99 into felixvanoost:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphviz isn't working
2 participants