Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphviz isn't working #21

Closed
ChrisOboe opened this issue Feb 23, 2024 · 2 comments · Fixed by #22
Closed

graphviz isn't working #21

ChrisOboe opened this issue Feb 23, 2024 · 2 comments · Fixed by #22
Labels
bug Something isn't working

Comments

@ChrisOboe
Copy link
Contributor

Hi,

i can't get it to work with graphviz.

here is the relevant part of my file:

'''plantuml
participant Jekyll
participant Kroki #MediumSpringGreen

Jekyll -> Kroki: Encoded diagram description
Kroki --> Jekyll: Rendered diagram in SVG format
'''

'''graphviz
digraph "test" {
 a -> b
}
'''

i replaced the backticks ` with the ' because otherwise github issues messes the rendering up.

i get the following log:

[jekyll-kroki] Rendered 1 diagrams using Kroki instance at 'https://kroki.io/'
                    done in 0.784 seconds.

the plantuml part is rendered correctly, the graphviz part isn't rendered at all. i only see the plaintext.
I'm not sure if i'm doing something wrong or if this is a bug.

@ChrisOboe
Copy link
Contributor Author

i investigated this a bit further. it seems jekyll generates different html output for plantuml and graphviz.
for plantuml i get

<pre>
<code class="language-plantuml">
...

for graphviz i get

<div class="language-graphviz highligter-rogue">
...

i'm neither a ruby dev nor a experienced jekyll user so i'm not sure whats the proper way of fixing would be.

@felixvanoost felixvanoost self-assigned this Feb 27, 2024
@felixvanoost felixvanoost added the bug Something isn't working label Feb 27, 2024
@felixvanoost felixvanoost removed their assignment Feb 27, 2024
@felixvanoost
Copy link
Owner

I was able to repoduce this bug and also confirm that your PR #22 fixed it:

[jekyll-kroki] Rendered 2 diagrams using Kroki instance at 'https://kroki.io/'
                    done in 0.338 seconds.
 Auto-regeneration: disabled. Use --watch to enable.

Screenshot 2024-02-26 231723

Thanks again and happy to hear that someone else found this plugin useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants