Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge magnetic forward functions for dipoles #453

Merged
merged 21 commits into from
Mar 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c20cad0
Start drafting merge of forward functions for dipoles
santisoler Jan 27, 2024
724c24a
Finish merge of forward functions
santisoler Jan 29, 2024
b5ad3f0
Update tests for dipole
santisoler Jan 29, 2024
645557f
Update user guide page on dipoles
santisoler Jan 29, 2024
6755cde
Push remove test of invalid magnetic moments with checks disabled
santisoler Mar 1, 2024
b6dd25e
Merge branch 'main' into merge-dipole-forwards
santisoler Mar 1, 2024
7281491
Run isort
santisoler Mar 1, 2024
b230813
Merge branch 'merge-dipole-forwards' of github.com:fatiando/harmonica…
santisoler Mar 1, 2024
95a30d8
Fix dipole example
santisoler Mar 1, 2024
9a2ba64
Remove dipole_magnetic_component from the API reference
santisoler Mar 1, 2024
769cada
Remove old private function that is not needed anymore
santisoler Mar 2, 2024
0c23a5a
Merge branch 'main' into merge-dipole-forwards
santisoler Mar 5, 2024
d89c2e4
Use VALID_FIELDS in pytest parametrizations
santisoler Mar 5, 2024
7c1e26b
Add test with disabled checks
santisoler Mar 5, 2024
6569afd
Merge branch 'main' into merge-dipole-forwards
santisoler Mar 12, 2024
3cf990a
Merge branch 'main' into merge-dipole-forwards
santisoler Mar 22, 2024
52793d8
Fix docstring of private function
santisoler Mar 22, 2024
65460b3
Improve docstring of dipole_magnetic
santisoler Mar 22, 2024
ed9cea0
Fix mistake in inline comment
santisoler Mar 26, 2024
c653a67
Specify units of the output mag field component
santisoler Mar 26, 2024
8068861
Merge branch 'main' into merge-dipole-forwards
santisoler Mar 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove old private function that is not needed anymore
  • Loading branch information
santisoler committed Mar 2, 2024
commit 769cadaa2422d718845466eb02f35b64c4619014
24 changes: 0 additions & 24 deletions harmonica/_forward/dipole.py
Original file line number Diff line number Diff line change
Expand Up @@ -389,30 +389,6 @@ def _jit_dipole_magnetic_component_cartesian(
progress_proxy.update(1)


def _get_magnetic_forward_function(component):
"""
Returns the Choclo magnetic forward modelling function for the desired
component

Parameters
----------
component : str
Magnetic field component.

Returns
-------
forward_function : callable
Forward modelling function for the desired component.
"""
if component not in ("easting", "northing", "upward"):
raise ValueError(
f"Invalid component '{component}'. "
"It must be either 'easting', 'northing' or 'upward'."
)
functions = {"easting": magnetic_e, "northing": magnetic_n, "upward": magnetic_u}
return functions[component]


_jit_dipole_magnetic_field_cartesian_serial = jit(nopython=True)(
_jit_dipole_magnetic_field_cartesian
)
Expand Down