Merge magnetic forward functions for dipoles #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the new specification for magnetic moments of dipoles, passing an invalid tuple of magnetic moments with `disable_checks=True` will fail, so the tests can be safely removed.
… into merge-dipole-forwards
|
@indiauppal I think this is ready to be merged. Would you like to take a look at it and review it? Feel free to say no if you don't feel like it, no pressure! |
indiauppal
reviewed
Mar 26, 2024
Replace "prisms" for "dipoles"
santisoler
commented
Mar 26, 2024
|
Thanks a lot @indiauppal! Just pushed two minor changes I caught, nothing critical. After CI passes I'll merge this. Hope these changes turn out to be helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the two forward functions for magnetic fields of dipoles into a single one named
dipole_magneticthat includes a newfieldargument. Make thedipole_magneticfunction to ask magnetic moment vectors as a tuple of three arrays, where each one of these arrays. Update tests accordingly. Update the user guide page about forward modelling of prisms.Relevant issues/PRs:
Fixes #450
Implements the same interface as #448