Add magnetic field forward modelling of rectangular prisms #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the computation of the magnetic fields of prisms in different functtions: `prism_magnetic_field` returns a tuple with the three components, `prism_magnetic_easting`, `prism_magnetic_northing` and `prism_magnetic_upward` return a single component.
Keep only two functions: `prism_magnetic` computes the three components of the magnetic field, while `prism_magnetic_component` returns only one, where the choice must be done through the `component` argument. Based on the idea brought by @aguspesce in one of the Fatiando Community Calls.
Update the magnetic forward modelling functions so they pass the prisms boundaries and magnetization vectors to the Choclo functions as scalars. This change was triggered by the modifications introduced in fatiando/choclo#50
7 tasks
santisoler
commented
May 19, 2023
santisoler
commented
May 19, 2023
santisoler
commented
May 19, 2023
santisoler
changed the title
LL-Geo
reviewed
Sep 27, 2023
|
Awesome @LL-Geo! Thanks for the review and for the swift merge! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add forward modelling functions that calculate the magnetic fields of rectangular prisms. One function efficiently computes the three components of the magnetic field, while the other one calculates just one component. The functions make use of Choclo's forward modelling functions, while providing a nice interface, sanity checks and parallelization through Numba. Add examples and tests.
Relevant issues/PRs:
Related to #406