-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward model magnetic properties of prism_layer #399
Comments
Hi @markgrujic! Thanks for opening this issue. We are aware that a lot of people will benefit from having forward modelling of magnetic fields in Harmonica (see https://github.com/orgs/fatiando/discussions/100 and https://github.com/orgs/fatiando/discussions/102). The good news is that we are working on it. All the kernels for the magnetic fields of prisms and dipoles live in Choclo and I've started a PR for adding magnetic forward modelling functions for prisms (see #369). I think @aguspesce will start working on adding a We'll be glad if you would like to contribute! Is there anything that you would like to start working on? |
Hello @santisoler and @markgrujic I will start to work on this today! |
Aha, perfect! Makes sense to keep the kernels in choclo 🌽. I'll keep an eye on this and those linked discussions. Cheers |
Description of the desired feature:
There are certain scenarios where forward modelling the magnetic effect of layers is meaningful (e.g. topography).
It seems that prism_layer can be used to define these layers and perhaps even assign magnetic properties, however there does not appear to be a mag equivalent to prism_gravity to perform the forward operation for the magnetic field.
I can think of some things that would be needed, including:
DatasetAccessorPrismLayer
so that prism_layer.magnetic could call harmonica.prism_magneticdispatcher
to account for gravity or magAre you willing to help implement and maintain this feature?
Happy to help where I can, probably best suited to testing though!
The text was updated successfully, but these errors were encountered: