Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set lower bounds for supported dependency versions #356

Merged
merged 5 commits into from
Nov 2, 2022

Conversation

leouieda
Copy link
Member

Follow NEP29 and set lower bounds for the dependencies (all minor versions from the last 2 years). The only exception is xrft, which is new and likely requires v1.0 to work with Harmonica. Setup CI to run on lowest Python with lowest dependencies, highest Python with highest dependencies, and highest Python with optional dependencies. Use Dependente to extract the version information from setup.cfg instead of the custom export tool we had.

Relevant issues/PRs:

leouieda and others added 4 commits October 26, 2022 16:09
Follow NEP29 and set lower bounds for the dependencies (all minor
versions from the last 2 years). The only exception is xrft, which is
new and likely requires v1.0 to work with Harmonica. Setup CI to run on
lowest Python with lowest dependencies, highest Python with highest
dependencies, and highest Python with optional dependencies. Use
Dependente to extract the version information from setup.cfg instead of
the custom export tool we had.
Some of the test we are running depend on the grid method of Verde
gridders to allow the get coordinates as arguments. This feature was
added in Verde 1.7.0.
@leouieda leouieda marked this pull request as ready for review October 27, 2022 05:56
@leouieda leouieda marked this pull request as draft October 27, 2022 05:56
@leouieda
Copy link
Member Author

@santisoler could we make the Actions checks not required? In practice we do require them but it's always a pain when we update the actions themselves, even if just changing a title here or there.

@leouieda leouieda marked this pull request as ready for review October 27, 2022 09:21
@santisoler santisoler merged commit e1bd291 into main Nov 2, 2022
@santisoler santisoler deleted the dependency-lower-bounds branch November 2, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants