Use original ETOPO1 heights and cast ints to float #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ETOPO1 is referenced to sea level. I had used a geoid model to convert it to geometric heights but this is not a great idea. Revert back to the original. The data were stored as ints to save space but this can cause problems with divisions and other operations. Cast them back to float after loading with our functions. Fixes #29 Fixes #30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ETOPO1 is referenced to sea level. I had used a geoid model to convert
it to geometric heights but this is not a great idea. Revert back to the
original. The data were stored as ints to save space but this can cause
problems with divisions and other operations. Cast them back to float
after loading with our functions.
Fixes #29
Fixes #30