-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interger values in sample grids should be converted to float #30
Labels
enhancement
Idea or request for a new feature
good first issue
Good for newcomers (doesn’t require deep knowledge of the project)
Milestone
Comments
leouieda
added a commit
that referenced
this issue
Dec 13, 2018
ETOPO1 is referenced to sea level. I had used a geoid model to convert it to geometric heights but this is not a great idea. Revert back to the original. The data were stored as ints to save space but this can cause problems with divisions and other operations. Cast them back to float after loading with our functions. Fixes #29 Fixes #30
leouieda
added a commit
that referenced
this issue
Dec 14, 2018
ETOPO1 is referenced to sea level. I had used a geoid model to convert it to geometric heights but this is not a great idea. Revert back to the original. The data were stored as ints to save space but this can cause problems with divisions and other operations. Cast them back to float after loading with our functions. Fixes #29 Fixes #30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Idea or request for a new feature
good first issue
Good for newcomers (doesn’t require deep knowledge of the project)
Description of the desired feature
The height in our sample gravity and topography are stored as integers to save space. However, this can cause problems in computations involving division. To avoid having to explain this to users or add warnings, we should convert these data types to
float32
in thefetch_*
functions once they are loaded.The text was updated successfully, but these errors were encountered: