Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new pylint 2.4.1 warnings #105

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Fix new pylint 2.4.1 warnings #105

merged 1 commit into from
Sep 26, 2019

Conversation

leouieda
Copy link
Member

The unsubscriptable-object warning causes some false positives so it's
best to disable it until it's more stable.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

The unsubscriptable-object warning causes some false positives so it's
best to disable it until it's more stable.
@leouieda leouieda mentioned this pull request Sep 26, 2019
5 tasks
@leouieda leouieda merged commit 71bfb75 into master Sep 26, 2019
@leouieda leouieda deleted the pylint branch September 26, 2019 15:12
santisoler added a commit to fatiando/rockhound that referenced this pull request Jan 10, 2020
Disable import-outside-toplevel pylint warning on rockhound/__init__.py.
The warning was raised because pylint was being imported outside toplevel.
Inspired on fatiando/harmonica#105.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant