Fix new pylint 2.4.1 warnings (#105)

The unsubscriptable-object warning causes some false positives so it's
best to disable it until it's more stable.

.pylintrc

@@ -50,7 +50,7 @@ confidence=
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
-disable=print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call,attribute-defined-outside-init,similarities,bad-continuation,import-error,assignment-from-no-return
+disable=print-statement,parameter-unpacking,unpacking-in-except,old-raise-syntax,backtick,long-suffix,old-ne-operator,old-octal-literal,raw-checker-failed,bad-inline-option,locally-disabled,locally-enabled,file-ignored,suppressed-message,deprecated-pragma,apply-builtin,basestring-builtin,buffer-builtin,cmp-builtin,coerce-builtin,execfile-builtin,file-builtin,long-builtin,raw_input-builtin,reduce-builtin,standarderror-builtin,unicode-builtin,xrange-builtin,coerce-method,delslice-method,getslice-method,setslice-method,no-absolute-import,old-division,dict-iter-method,dict-view-method,next-method-called,metaclass-assignment,indexing-exception,raising-string,reload-builtin,oct-method,hex-method,nonzero-method,cmp-method,input-builtin,round-builtin,intern-builtin,unichr-builtin,map-builtin-not-iterating,zip-builtin-not-iterating,range-builtin-not-iterating,filter-builtin-not-iterating,using-cmp-argument,eq-without-hash,div-method,idiv-method,rdiv-method,exception-message-attribute,invalid-str-codec,sys-max-int,bad-python3-import,deprecated-string-function,deprecated-str-translate-call,attribute-defined-outside-init,similarities,bad-continuation,import-error,assignment-from-no-return,unsubscriptable-object
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

harmonica/__init__.py

@@ -1,4 +1,4 @@
-# pylint: disable=missing-docstring
+# pylint: disable=missing-docstring,import-outside-toplevel
 # Import functions/classes to make the public API
 from . import version
 from . import datasets

harmonica/tests/test_icgem.py

@@ -85,8 +85,7 @@ def test_missing_shape(tmpdir):
  for line in gdf_file:
  if attribute in line:
  continue
- else:
- corrupt_gdf.write(line)
+ corrupt_gdf.write(line)
  with raises(IOError):
  load_icgem_gdf(corrupt)
 
@@ -101,8 +100,7 @@ def test_missing_size(tmpdir):
  for line in gdf_file:
  if attribute in line:
  continue
- else:
- corrupt_gdf.write(line)
+ corrupt_gdf.write(line)
  with raises(IOError):
  load_icgem_gdf(corrupt)
 
@@ -135,8 +133,7 @@ def test_missing_cols_names(tmpdir):
  for line in gdf_file:
  if "latitude" in line and "longitude" in line:
  continue
- else:
- corrupt_gdf.write(line)
+ corrupt_gdf.write(line)
  with raises(IOError):
  load_icgem_gdf(corrupt)
 
@@ -150,8 +147,7 @@ def test_missing_units(tmpdir):
  for line in gdf_file:
  if "[mgal]" in line:
  continue
- else:
- corrupt_gdf.write(line)
+ corrupt_gdf.write(line)
  with raises(IOError):
  load_icgem_gdf(corrupt)
 
@@ -165,8 +161,7 @@ def test_missing_empty_line(tmpdir):
  for line in gdf_file:
  if not line.strip():
  continue
- else:
- corrupt_gdf.write(line)
+ corrupt_gdf.write(line)
  with raises(IOError):
  load_icgem_gdf(corrupt)
 
@@ -240,8 +235,7 @@ def test_missing_area(tmpdir):
  for line in gdf_file:
  if attribute in line:
  continue
- else:
- corrupt_gdf.write(line)
+ corrupt_gdf.write(line)
  with raises(IOError):
  load_icgem_gdf(corrupt)