Skip to content

Commit

Permalink
perf: move jupyter esm out of main snapshot (denoland#21163)
Browse files Browse the repository at this point in the history
  • Loading branch information
littledivy authored Nov 14, 2023
1 parent d342c0d commit ab0c637
Show file tree
Hide file tree
Showing 8 changed files with 363 additions and 348 deletions.
6 changes: 5 additions & 1 deletion cli/args/flags.rs
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ pub struct ReplFlags {
pub is_default_command: bool,
}

#[derive(Clone, Debug, Eq, PartialEq)]
#[derive(Clone, Debug, Eq, PartialEq, Default)]
pub struct RunFlags {
pub script: String,
pub watch: Option<WatchFlagsWithPaths>,
Expand Down Expand Up @@ -311,6 +311,10 @@ impl DenoSubcommand {
pub fn is_run(&self) -> bool {
matches!(self, Self::Run(_))
}

pub fn is_test_or_jupyter(&self) -> bool {
matches!(self, Self::Test(_) | Self::Jupyter(_))
}
}

impl Default for DenoSubcommand {
Expand Down
1 change: 0 additions & 1 deletion cli/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,6 @@ deno_core::extension!(
esm = [
dir "js",
"40_testing.js",
"40_jupyter.js",
"99_main.js"
],
customizer = |ext: &mut deno_core::Extension| {
Expand Down
1 change: 1 addition & 0 deletions cli/factory.rs
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,7 @@ impl CliFactory {

Ok(CliMainWorkerFactory::new(
StorageKeyResolver::from_options(&self.options),
self.options.sub_command().clone(),
npm_resolver.clone(),
node_resolver.clone(),
self.blob_store().clone(),
Expand Down
Loading

0 comments on commit ab0c637

Please sign in to comment.