perf: move jupyter esm out of main snapshot #21163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
changed the title
|
deno/cli/tests/unit/jupyter_test.ts Line 6 in b2e3389 Some unit tests depend on the jupyter internals object to be available during |
Hmpf, I forgot about that... Is there some internal flag we have that we could use to execute this file in internal unit tests? If not maybe we can add one? |
bartlomieju
reviewed
Nov 11, 2023
bartlomieju
reviewed
Nov 13, 2023
kt3k
pushed a commit
that referenced
this pull request
Nov 17, 2023
zifeo
pushed a commit
to metatypedev/deno
that referenced
this pull request
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #21136