-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expand Swift integration with Mint support #724
Conversation
Thank you! Have you tested this locally? |
I have tested the mint commands, yes. I haven't tested the toml file in this pr if that's what you're asking. |
@levibostian I mean, does the generated hook works as expected and I am not aware of Swift tools, so I'll rely on your experience :) |
Do you mind pointing me in the right direction as far as testing this pull request out? I looked at a couple other prs that did a similar modification and didn't find any help there. Maybe I'm looking in the wrong spot? Happy to test it out and answer your questions though! |
@levibostian Sure, to test this locally you can do the following:
|
Thanks for the help! Especially the tip on lefthook in my PATH. After I ran
LGTM! |
Let me check 1 more thing.... |
I wanted to check if you could specify a specific version of lefthook to run with mint. You can! If your project contains a LGTM |
Nice, thank you! I am going to merge this tomorrow and release with the next lefthook version 👌 |
Building on top of previous PR that added Swift support.
⚡ Summary
The
csjones/lefthook-plugin
Swift project has recently added mint package manager support. To advertise this functionality, I wanted to mention this new feature in the lefthook docs.For my edits in this PR, I used the previous PR that added Swift support as a reference. I have not tested
internal/templates/hook.tmpl
, if it's even possible to do so.Thanks!
☑️ Checklist