Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint support. Create executable target that runs lefthook binary from artifact bundle #4

Merged
merged 1 commit into from
Apr 20, 2024
Merged

Conversation

levibostian
Copy link
Contributor

Besides offering a swift plugin target, this commit adds an executable target to run lefthook. Having an executable target allows you to use tools like Mint to run lefthook.

The executable target supports both "swift run lefthook" and "mint run ..." for local development testing and mint testing.

… artifact bundle

Besides offering a swift plugin target, this commit adds an executable target to run lefthook. Having an executable target allows you to use tools like Mint to run lefthook.

The executable target supports both "swift run lefthook" and "mint run ..." for local development testing and mint testing.
@csjones
Copy link
Owner

csjones commented Apr 19, 2024

Thank you for opening this PR 🎉

After briefly looking at the implementation, the code looks great! I'll test later and plan to merge tomorrow.

Would you mind doing two last tasks to bring the integration full circle? Updating the README and adding mint to the hook.tmpl file in lefthook repository (similar to the swift plugin support)?

Thank you again, I appreciate you taking the time to work through the implementation details to make this feature happen 😁

@levibostian
Copy link
Contributor Author

PR opened for README updates.

I opened it as a separate PR to not block this one from merging if there was a lot of README changes requested.

I'll open a lefthook hook.tmpl PR next. 👍🏻

@levibostian
Copy link
Contributor Author

I have a lefthook branch ready to create a PR with the lefthook project.

To be respectful to that team's time, I'll wait to make that PR until all the mint PRs are merged into this project to verify it works.

@csjones csjones merged commit 6a7630f into csjones:PreBuildPlugin Apr 20, 2024
@levibostian levibostian deleted the PreBuildPlugin branch April 20, 2024 20:04
@csjones
Copy link
Owner

csjones commented Apr 20, 2024

Everything needed from our side to support mint is merged into main. Once your changes are merged in upstream and a new release is made, the shorthand mint usage (e.g. mint run csjones/lefthook-plugin) will start working. 🎉

@csjones
Copy link
Owner

csjones commented May 13, 2024

I have a lefthook branch ready to create a PR with the lefthook project.

Hey @levibostian, I wanted to follow up because lefthook recently made a new release but I haven't seen your branch of changes in the upstream repository. Are you still planning to open a PR?

@levibostian
Copy link
Contributor Author

Hey there, thanks for asking.

I can open it, yes. I'll open it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants