Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] Update attrs dependency #12

Merged
merged 10 commits into from
Sep 1, 2022
Merged

[PATCH] Update attrs dependency #12

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bfacf4e
Update attrs dependency
miguelsanchez-eb Aug 31, 2022
79979f8
Exclude build directory
miguelsanchez-eb Aug 31, 2022
a059c01
Fix freezegun version
miguelsanchez-eb Aug 31, 2022
3de5ae8
Fixed importlib-metadata version
miguelsanchez-eb Aug 31, 2022
433d076
Ignore "build" dir
miguelsanchez-eb Aug 31, 2022
bb9470b
Add comments
miguelsanchez-eb Aug 31, 2022
04b0582
Fix typing in tests
miguelsanchez-eb Sep 1, 2022
eaf2c0d
Remove verbose parentheses
miguelsanchez-eb Sep 1, 2022
baf6957
Importlib-metadata as dependency
miguelsanchez-eb Sep 1, 2022
d39c309
Improve comments
miguelsanchez-eb Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove verbose parentheses
  • Loading branch information
@miguelsanchez-eb
miguelsanchez-eb committed Sep 1, 2022
commit eaf2c0df6e14cba3db2454b11040174c98bdc490
16 changes: 8 additions & 8 deletions tests/unit/recorders/test_default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,11 +579,11 @@ def se():
mock_publish.reset_mock()

recorder.unpublished_metrics_count = 1
frozen_time.tick(datetime.timedelta(seconds=(9)))
frozen_time.tick(datetime.timedelta(seconds=9))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tick method expects a delta, not an integer
https://github.com/spulec/freezegun/blob/master/freezegun/api.pyi#L23

recorder.publish_if_full_or_old()
assert mock_publish.call_count == 0

frozen_time.tick(datetime.timedelta(seconds=(1)))
frozen_time.tick(datetime.timedelta(seconds=1))
recorder.publish_if_full_or_old()
mock_publish.assert_called_once_with()
mock_publish.reset_mock()
Expand All @@ -592,11 +592,11 @@ def se():
recorder.publish_if_full_or_old()
assert mock_publish.call_count == 0

frozen_time.tick(datetime.timedelta(seconds=(13)))
frozen_time.tick(datetime.timedelta(seconds=13))
recorder.publish_if_full_or_old(max_age=14)
assert mock_publish.call_count == 0

frozen_time.tick(datetime.timedelta(seconds=(1)))
frozen_time.tick(datetime.timedelta(seconds=1))
recorder.publish_if_full_or_old()
mock_publish.assert_called_once_with()
mock_publish.reset_mock()
Expand All @@ -621,11 +621,11 @@ def se():
recorder.throttled_publish_all()
assert mock_publish.call_count == 0

frozen_time.tick(datetime.timedelta(seconds=(9)))
frozen_time.tick(datetime.timedelta(seconds=9))
recorder.throttled_publish_all()
assert mock_publish.call_count == 0

frozen_time.tick(datetime.timedelta(seconds=(1)))
frozen_time.tick(datetime.timedelta(seconds=1))
recorder.throttled_publish_all()
mock_publish.assert_called_once_with()
mock_publish.reset_mock()
Expand All @@ -634,11 +634,11 @@ def se():
recorder.throttled_publish_all()
assert mock_publish.call_count == 0

frozen_time.tick(datetime.timedelta(seconds=(13)))
frozen_time.tick(datetime.timedelta(seconds=13))
recorder.throttled_publish_all(14)
assert mock_publish.call_count == 0

frozen_time.tick(datetime.timedelta(seconds=(1)))
frozen_time.tick(datetime.timedelta(seconds=1))
recorder.throttled_publish_all()
mock_publish.assert_called_once_with()
mock_publish.reset_mock()