[PATCH] Update attrs dependency #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsanchez-eb
changed the title
miguelsanchez-eb
commented
Sep 1, 2022
| @@ -578,11 +579,11 @@ def se(): | |||
| mock_publish.reset_mock() | |||
|
|
|||
| recorder.unpublished_metrics_count = 1 | |||
| frozen_time.tick(9) | |||
| frozen_time.tick(datetime.timedelta(seconds=9)) | |||
There was a problem hiding this comment.
tick method expects a delta, not an integer
https://github.com/spulec/freezegun/blob/master/freezegun/api.pyi#L23
eb-jesuseraso
approved these changes
Sep 1, 2022
miguelsanchez-eb
added a commit
that referenced
this pull request
Sep 1, 2022
Changelog Details: - [PATCH] Update attrs dependency (#12)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relax the attrs dependency, which was fixed in an old version that presented incompatibilities with some modern used in the company such as aws_cdk.