-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esp-rfid v2 #605
base: stable
Are you sure you want to change the base?
esp-rfid v2 #605
Conversation
Wiegand Keypad support
Logfile fixes part 1
remove BSSID, speed up wifi connect
ISR IRAM fix and compatibility with esp 2.2.3
Logfile fixes part2
Thank you @omersiar! Meanwhile I've deployed it on our system at the local Fablab and found a little bug about the old config compatibility :) If you can approve again would be nice :) I'll leave the PR open for a couple weeks just in case I find anything else or if anyone testing finds any issue. Thank you Omer!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Better version built on existing idea
Update rfid.esp
RFID uid fix
deserializeJson needs size if it's not a zero-terminated string
(accountTypes[0] == ACCESS_GRANTED) will always be true if we got this far
Commits abd0e66 and 20e4dcb fixed how UIDs are converted to strings. Previously some '0's in the UID would be missed, meaning the old stored UIDs were actually incorrect. This had the effect of meaning esp-rfid v2 is not compatible with all users from v1. To fix this we create UIDs at scan time in both the new (fixed) format and the old (broken) format, and check the database for both.
don't process JSON past the end of the buffer
Fix activation logic for extra relays
Use correct label for extra relays when editing user
Ensure users are compatible between v1 and v2
helps us mere mortals can understand what's happening :) also quote username in debug output for clarity
Couple of small updates to rfid.esp and add more comments
Fix for NTP blocking loop if connection is blocked
Doesn't keep the door open for 10 seconds!
Fix opening door while disconnected
Access logs were missing a lot of access denied, which are now added and the UI was displaying only the role of the person trying the access, not the actual result. So now we are logging the card, the role and the result of the opening. For example a standard card could have failed because it has expired, it's disabled or it's outside of the opening hours. In all these cases we should add a line in the access logs saying that the person with the specific role had a denied access.
Fix access logs and visualization
This was affecting the user list and the user export
Fix pincode reading in websocket
I think it's time to release a V2 for esp-rfid :)
We need a V2 as there are a few breaking changes on the MQTT interface, but I think it's much better now.
Apart from that, the update from V1 should just work, the old configuration will work on the V2 and the new stuff should default to settings that should keep the old configuration working. If anyone has problems upgrading let me know!
I have updated all the documentation and apart from a merge with stable and a changelog update we should be ready!!
@omersiar let me know what you think :)