RFID uid fix #613
Merged
RFID uid fix #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better version built on existing idea
Update rfid.esp
|
@plex3r please keep just one PR open between this one and the other one and let's hope that @Divyastra can test and confirm :) |
|
@matjack1 I've closed the other one as this one is in line with the original sentiment of the code that was being tried Thanks |
|
OK, nice, let's wait for a test from someone else as I don't have this specific reader yet :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified rfid.esp as current code was giving 0 uid's regardless this code works with uid's containing 0