Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix no-constructor-return schema #17049

Closed
wants to merge 1 commit into from

Conversation

Dimava
Copy link

@Dimava Dimava commented Apr 1, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

eslint-types/eslint-define-config#140

What changes did you make? (Give an overview)

The no-constructor-return rule has empty schema, as can be seen on https://eslint.org/docs/latest/rules/no-constructor-return

However, it's schema is incorrectly whitten as {} instead of [] which breaks type codegen of eslint-define-config

This PR changes the incorrect {} empty schema to []

@Dimava Dimava requested a review from a team as a code owner April 1, 2023 17:46
@linux-foundation-easycla
Copy link

CLA Not Signed

@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Apr 1, 2023
@netlify
Copy link

netlify bot commented Apr 1, 2023

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 509fbee
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/64286dfec7bb06000845e53d

@mdjermanovic
Copy link
Member

mdjermanovic commented Apr 1, 2023

Hi @Dimava!

Per our semver policies, this is a breaking change ("Major release > Part of the public API is removed or changed in an incompatible way > Rule schemas"). Since we don't have a timeline for v9 yet, I'm closing this PR but will add this task to #16574 #16879.

@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Sep 29, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants