Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating eslint/no-constructor-return results in a type error #140

Closed
Shinigami92 opened this issue Oct 4, 2022 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@Shinigami92
Copy link
Collaborator

image

@Shinigami92 Shinigami92 added the bug Something isn't working label Oct 4, 2022
@Dimava
Copy link
Contributor

Dimava commented Apr 1, 2023

Actually that seems to be eslint bug

The rule schema is an empty object {} instead of an empty array [] it should be

https://github.com/eslint/eslint/blob/main/lib/rules/no-constructor-return.js#L23

@Dimava
Copy link
Contributor

Dimava commented Apr 2, 2023

@Shinigami92 so, that's a breaking change for eslint, thus not anytime soon

(see: eslint/eslint#17049 , eslint/eslint#16879 )

Should we close this with #180 ?

@Shinigami92
Copy link
Collaborator Author

This was solved by #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants