fix(ext/node): make process.versions own property (denoland#24240)

eryue0220 · Jun 18, 2024 · 10ac3bb · 10ac3bb
1 parent 8c4b33d
commit 10ac3bb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/ext/node/polyfills/process.ts b/ext/node/polyfills/process.ts
@@ -731,6 +731,9 @@ if (isWindows) {
 // @ts-ignore TS doesn't work well with ES5 classes
 const process = new Process();
 
+/* Set owned property */
+process.versions = versions;
+
 Object.defineProperty(process, Symbol.toStringTag, {
  enumerable: false,
  writable: true,

diff --git a/tests/unit_node/process_test.ts b/tests/unit_node/process_test.ts
@@ -1116,3 +1116,7 @@ Deno.test("process.listeners - include SIG* events", () => {
  process.off("SIGINT", listener2);
  assertEquals(process.listeners("SIGINT").length, 0);
 });
+
+Deno.test(function processVersionsOwnProperty() {
+ assert(Object.prototype.hasOwnProperty.call(process, "versions"));
+});