Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): make process.versions own property #24240

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

littledivy
Copy link
Member

Fixes #24233

This is a quick fix. There are some more properties that should be on the object rather than the class, this'll do for now

[divy@divy deno]$ target/debug/deno
Deno 1.44.2
exit using ctrl+d, ctrl+c, or close()
REPL is running with all permissions allowed.
To specify permissions, run `deno repl` with allow flags.
> import { ClientSecretCredential } from "npm:@azure/identity";
const test = new ClientSecretCredential("a","b","c",);
console.log(test);
ClientSecretCredential {
  clientSecret: "c",
  tenantId: "a",
  additionallyAllowedTenantIds: [],
  msalClient: {
    getTokenByClientSecret: [AsyncFunction: getTokenByClientSecret],
    getTokenByClientAssertion: [AsyncFunction: getTokenByClientAssertion],
    getTokenByClientCertificate: [AsyncFunction: getTokenByClientCertificate]
  }
}

Fixes denoland#24233

This is a quick fix. There are some more properties that should be on
the object rather than the class, this'll do for now
@littledivy littledivy merged commit 10ac3bb into denoland:main Jun 18, 2024
17 checks passed
@littledivy littledivy deleted the versions_owned_property branch June 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"node:process" is broken in "@azure/identity" since v1.43.6
2 participants