Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor parser #144

Merged
merged 20 commits into from
Dec 10, 2022
Merged

feat: refactor parser #144

merged 20 commits into from
Dec 10, 2022

Conversation

erdos
Copy link
Owner

@erdos erdos commented Dec 8, 2022

Refactor stencil expression parser to use parser combinators instead of the Shunting-Yard algorithm.

This change will make it easier to extend the syntax and add error handling.

Our mid-term plan is to associate metadata with the AST nodes of the expressions, which will hold debug information for generating useful error messages.

@erdos erdos added the syntax template language syntax label Dec 8, 2022
wip

wip

wiop

fixes

fix unless
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #144 (14fb45b) into master (83a8dd2) will increase coverage by 0.80%.
The diff coverage is 96.52%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   92.30%   93.10%   +0.80%     
==========================================
  Files          26       27       +1     
  Lines        1898     1872      -26     
  Branches      105      104       -1     
==========================================
- Hits         1752     1743       -9     
+ Misses         41       25      -16     
+ Partials      105      104       -1     
Impacted Files Coverage Δ
src/stencil/cleanup.clj 94.77% <86.66%> (-0.54%) ⬇️
src/stencil/infix.clj 98.96% <97.91%> (+10.14%) ⬆️
src/stencil/grammar.clj 98.00% <98.00%> (ø)
src/stencil/tokenizer.clj 96.77% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erdos erdos mentioned this pull request Dec 9, 2022
1 task
@erdos erdos merged commit 27335c3 into master Dec 10, 2022
@erdos erdos deleted the feat-grammar branch December 10, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
syntax template language syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant