feat: refactor parser #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 92.30% 93.10% +0.80%
==========================================
Files 26 27 +1
Lines 1898 1872 -26
Branches 105 104 -1
==========================================
- Hits 1752 1743 -9
+ Misses 41 25 -16
+ Partials 105 104 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor stencil expression parser to use parser combinators instead of the Shunting-Yard algorithm.
This change will make it easier to extend the syntax and add error handling.
Our mid-term plan is to associate metadata with the AST nodes of the expressions, which will hold debug information for generating useful error messages.