Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lookup arity #127

Closed
wants to merge 2 commits into from
Closed

fix: lookup arity #127

wants to merge 2 commits into from

Conversation

erdos
Copy link
Owner

@erdos erdos commented May 29, 2022

stencil throws an exception when access with [] and with dotted form is mixed in a single expression, like in x[y].z.

TODO:

  • check if it breaks variable name enumeration

@erdos erdos added the syntax template language syntax label May 29, 2022
@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #127 (14a7ae9) into master (04586c1) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   93.07%   93.00%   -0.08%     
==========================================
  Files          25       25              
  Lines        1893     1902       +9     
  Branches      107      108       +1     
==========================================
+ Hits         1762     1769       +7     
- Misses         24       25       +1     
- Partials      107      108       +1     
Impacted Files Coverage Δ
src/stencil/infix.clj 98.38% <100.00%> (+0.04%) ⬆️
src/stencil/functions.clj 87.17% <0.00%> (-0.83%) ⬇️
src/stencil/cleanup.clj 92.75% <0.00%> (-0.73%) ⬇️
src/stencil/ooxml.clj 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04586c1...14a7ae9. Read the comment docs.

@erdos
Copy link
Owner Author

erdos commented Dec 9, 2022

Will be addressed in #144

@erdos erdos closed this Dec 9, 2022
@erdos erdos deleted the fix-lookup-arity branch December 9, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
syntax template language syntax
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant