Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: updating stable release instructions and owner #13588

Merged
merged 6 commits into from
Oct 21, 2020
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion GOVERNANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ or you can subscribe to the iCal feed [here](webcal:https://kubernetes.app.opsgenie.co
* Remove the "Pending" tags and add dates to the top of the [release notes for this version](docs/root/version_history/current.rst).
* Switch the [VERSION](VERSION) from a "dev" variant to a final variant. E.g., "1.6.0-dev" to
"1.6.0".
* Update the [RELEASES](RELEASES.md) doc with the relevant dates.
* Update the [RELEASES](RELEASES.md) doc with the relevant dates. Now, or after you cut the
release, please also make sure there's a stable maintainer signed up for next quarter,
and the deadline for the next release is documented in the release schedule.
* Get a review and merge.
* Wait for tests to pass on [master](https://dev.azure.com/cncf/envoy/_build).
* Create a [tagged release](https://github.com/envoyproxy/envoy/releases). The release should
Expand Down
13 changes: 7 additions & 6 deletions RELEASES.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,13 @@ schedule, initially aiming for the bi-weekly releases.
Release managers of stable releases are responsible for approving and merging backports, tagging
stable releases and sending announcements about them. This role is rotating on a quarterly basis.

| Quarter | Release manager |
|:-------:|:----------------------------:|
| 2020 Q1 | Piotr Sikora ([PiotrSikora]) |
| 2020 Q2 | Piotr Sikora ([PiotrSikora]) |
| 2020 Q3 | Yuchen Dai ([lambdai]) |
| Quarter | Release manager |
|:-------:|:--------------------------------------------------------------:|
| 2020 Q1 | Piotr Sikora ([PiotrSikora](https://github.com/PiotrSikora)) |
| 2020 Q2 | Piotr Sikora ([PiotrSikora](https://github.com/PiotrSikora)) |
| 2020 Q3 | Yuchen Dai ([lambdai](https://github.com/lambdai)) |
| 2020 Q4 | Christoph Pakulski ([cpakulski](https://github.com/cpakulski)) |
| 2021 Q1 | Rei Shimizu ([shikugawa](https://github.com/shikugawa)) |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those links don't point anywhere right now (see the last line in this file). I think it might be better to inline links here, otherwise we keep missing the link targets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good call, I'd missed those entirely

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/shikugawa/Shikugawa/

## Release schedule

Expand All @@ -69,4 +71,3 @@ deadline of 3 weeks.


[repokitteh]: https://github.com/repokitteh
[PiotrSikora]: https://github.com/PiotrSikora