-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: updating stable release instructions and owner #13588
Conversation
Signed-off-by: Alyssa Wilk <[email protected]>
@lizan tells me @cpakulski is up for being stable maintainer this quarter - updating docs accordingly. Thanks so much Christoph! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cpakulski and @Shikugawa!
RELEASES.md
Outdated
| 2020 Q2 | Piotr Sikora ([PiotrSikora]) | | ||
| 2020 Q3 | Yuchen Dai ([lambdai]) | | ||
| 2020 Q4 | Christoph Pakulski ([cpakulski]) | | ||
| 2021 Q1 | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, Rei Shimizu (@Shikugawa) agreed to be signed up in the next release. We can leave this updated at release 1.17 or just update now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh awesome, thanks @Shikugawa
Also a huge thanks to @lambdai and @PiotrSikora for their work thusfar! :-)
Signed-off-by: Alyssa Wilk <[email protected]>
| 2020 Q2 | Piotr Sikora ([PiotrSikora]) | | ||
| 2020 Q3 | Yuchen Dai ([lambdai]) | | ||
| 2020 Q4 | Christoph Pakulski ([cpakulski]) | | ||
| 2021 Q1 | Rei Shimizu (@Shikugawa) | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those links don't point anywhere right now (see the last line in this file). I think it might be better to inline links here, otherwise we keep missing the link targets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, good call, I'd missed those entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: s/shikugawa/Shikugawa/
Signed-off-by: Alyssa Wilk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once Rei's GitHub is fixed.
| 2020 Q2 | Piotr Sikora ([PiotrSikora]) | | ||
| 2020 Q3 | Yuchen Dai ([lambdai]) | | ||
| 2020 Q4 | Christoph Pakulski ([cpakulski]) | | ||
| 2021 Q1 | Rei Shimizu (@Shikugawa) | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: s/shikugawa/Shikugawa/
Signed-off-by: Alyssa Wilk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Alyssa Wilk <[email protected]>
/retest |
Retrying Azure Pipelines. |
Signed-off-by: Alyssa Wilk <[email protected]>
Risk Level: n/a
Testing: n/a
Docs Changes: yes
Release Notes: no