Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: updating stable release instructions and owner #13588

Merged
merged 6 commits into from
Oct 21, 2020

Conversation

alyssawilk
Copy link
Contributor

Risk Level: n/a
Testing: n/a
Docs Changes: yes
Release Notes: no

@alyssawilk
Copy link
Contributor Author

@lizan tells me @cpakulski is up for being stable maintainer this quarter - updating docs accordingly. Thanks so much Christoph!

lizan
lizan previously approved these changes Oct 15, 2020
Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cpakulski and @Shikugawa!

RELEASES.md Outdated
| 2020 Q2 | Piotr Sikora ([PiotrSikora]) |
| 2020 Q3 | Yuchen Dai ([lambdai]) |
| 2020 Q4 | Christoph Pakulski ([cpakulski]) |
| 2021 Q1 | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, Rei Shimizu (@Shikugawa) agreed to be signed up in the next release. We can leave this updated at release 1.17 or just update now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh awesome, thanks @Shikugawa
Also a huge thanks to @lambdai and @PiotrSikora for their work thusfar! :-)

| 2020 Q2 | Piotr Sikora ([PiotrSikora]) |
| 2020 Q3 | Yuchen Dai ([lambdai]) |
| 2020 Q4 | Christoph Pakulski ([cpakulski]) |
| 2021 Q1 | Rei Shimizu (@Shikugawa) |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those links don't point anywhere right now (see the last line in this file). I think it might be better to inline links here, otherwise we keep missing the link targets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, good call, I'd missed those entirely

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/shikugawa/Shikugawa/

@lizan lizan added the waiting label Oct 16, 2020
Signed-off-by: Alyssa Wilk <[email protected]>
PiotrSikora
PiotrSikora previously approved these changes Oct 19, 2020
Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once Rei's GitHub is fixed.

| 2020 Q2 | Piotr Sikora ([PiotrSikora]) |
| 2020 Q3 | Yuchen Dai ([lambdai]) |
| 2020 Q4 | Christoph Pakulski ([cpakulski]) |
| 2021 Q1 | Rei Shimizu (@Shikugawa) |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/shikugawa/Shikugawa/

S
Signed-off-by: Alyssa Wilk <[email protected]>
Copy link
Contributor

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@asraa
Copy link
Contributor

asraa commented Oct 21, 2020

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #13588 (comment) was created by @asraa.

see: more, trace.

@alyssawilk alyssawilk merged commit 0d643e2 into envoyproxy:master Oct 21, 2020
@alyssawilk alyssawilk deleted the stable branch June 10, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants