Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test script #451

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Add test script #451

merged 1 commit into from
Oct 12, 2019

Conversation

florimondmanca
Copy link
Member

@florimondmanca florimondmanca commented Oct 5, 2019

Prompted by #399 (comment)

Running

$ scripts/test

runs the test suite and runs the check session.

I made it so that the test suite only for the current Python version is run (e.g. 3.7), but we could also run $ nox -s test so that all available Python versions are tested (e.g. all of 3.6, 3.7 and 3.8 if they're detected as available by nox). This is mostly because running tests against all Python versions can get very long, esp. because virtualenvs aren't reused. Thoughts?

@florimondmanca
Copy link
Member Author

I'm also wondering — what should we do about the contributing docs, since they currently recommend using $ nox -s test?

@pquentin
Copy link
Contributor

pquentin commented Oct 6, 2019

Would it help to configure nox to reuse virtual environments? There are various places where it can be done: https://nox.thea.codes/en/stable/config.html

@florimondmanca
Copy link
Member Author

@pquentin We actually reuse virtualenvs in all other nox sessions, but not in test. I think reusing would be OK in that case too though. We can always --no-reuse-existing-virtualenvs on the command line. I'll submit a separate PR for that. :)

docs/contributing.md Outdated Show resolved Hide resolved
@florimondmanca florimondmanca merged commit 5e4f54d into master Oct 12, 2019
@florimondmanca florimondmanca deleted the tooling/test-script branch October 12, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants