Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hints for debugging CI issues #399

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Add hints for debugging CI issues #399

merged 5 commits into from
Oct 10, 2019

Conversation

sethmlarson
Copy link
Contributor

Closes #311

florimondmanca
florimondmanca reviewed Sep 27, 2019
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Screenshots would bring an extra oompf, can we consider adding some?

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
docs/contributing.md Show resolved Hide resolved
@sethmlarson @florimondmanca
Update .github/CONTRIBUTING.md
33f5331 
Co-Authored-By: Florimond Manca <[email protected]>
@sethmlarson
Copy link
Contributor Author

Added some images, would like another review @florimondmanca or @yeraydiazdiaz! :)

@florimondmanca
Copy link
Member

Will try to take a look soon @sethmlarson. A bit short on time for the next few days though.

@florimondmanca florimondmanca mentioned this pull request Oct 5, 2019
Merged
florimondmanca
florimondmanca approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good for merging to me!

florimondmanca
florimondmanca approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor typo.

docs/contributing.md Outdated Show resolved Hide resolved
@sethmlarson sethmlarson merged commit a80c432 into master Oct 10, 2019
@sethmlarson sethmlarson deleted the issue-311 branch October 10, 2019 12:05
@sethmlarson
Copy link
Contributor Author

Thanks @florimondmanca!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie left review comments

@yeraydiazdiaz yeraydiazdiaz yeraydiazdiaz left review comments

@florimondmanca florimondmanca florimondmanca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributing Guide - Helping our users resolve build failures.
4 participants
@sethmlarson @florimondmanca @tomchristie @yeraydiazdiaz