Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python examples rework #27

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Python examples rework #27

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b2c523a
python: navio: add modules from Navio+
Nov 17, 2017
6c0c923
python: navio: Common: util: add new function
Nov 17, 2017
d33ddf9
python: navio: Navio: add Led Navio+ support
Nov 17, 2017
5520231
python: navio: Navio: add ADC Navio+ support
Nov 17, 2017
44e25f2
python: navio: Navio: add RCInput Navio+ support
Nov 17, 2017
75a406a
python: navio: Navio: add RCOutput Navio+ support
Nov 17, 2017
d4b5f83
python: navio: Navio2: RCInput: add channel number check
Nov 17, 2017
f2023ff
python: LED: add Navio+ support
Nov 17, 2017
8f67d05
python: AccelGyroMag: add Navio+ support
Nov 17, 2017
b241095
python: Barometer: rename modules
Nov 17, 2017
ccf53b5
python: GPS: rename modules
Nov 17, 2017
fd610e8
python: ADC: add Navio+ support
Nov 17, 2017
5a7a23a
python: RCInput: add Navio+ support
Nov 17, 2017
323675f
python: Servo: add Navio+ support
Nov 17, 2017
e5476c7
Python: apply black formatter for better readability
Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
python: navio: Navio2: RCInput: add channel number check 
Print error message if channel too large
  • Loading branch information
Igor Anokhin committed Jan 10, 2018
commit d4b5f834e631ae05d015f0af2bff0604f7848422
12 changes: 8 additions & 4 deletions Python/navio/Navio2/RCInput.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ def __init__(self):
print ("Can't open file /sys/kernel/rcio/rcin/ch%d" % i)

def read(self, ch):
value = self.channels[ch].read()
position = self.channels[ch].seek(0, 0)
return value[:-1]

try:
value = self.channels[ch].read()
position = self.channels[ch].seek(0, 0)
return value[:-1]
except IndexError:
print ("Channel number too large")
exit(1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to throw exception on higher level instead of exiting inside utility method