Break inheritance hierarchy in interfaces #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
requested review from
fnewberg,
bidetofevil and
a team
as code owners
fractalwrench
force-pushed
the
alter-interface-hierarchy
branch
from
d6dde01
to
b069d7a
Compare
fractalwrench
force-pushed
the
convert-emb-api
branch
from
5c03be0
to
bf74efd
Compare
fractalwrench
force-pushed
the
alter-interface-hierarchy
branch
from
b069d7a
to
8db9d49
Compare
Extract sdk state functions to delegate
Extract network calls into api delegate
Extract view tracking delegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Breaks an inheritance hierarchy in internal interfaces that would complicate our approach of API delegates. This shouldn't be a breaking change as the actual API implementation remains on
Embrace.java, and the interface was previously non-public.Testing
Relied on existing test coverage.